[ISSUE #383]support failed task after connector restart#386
[ISSUE #383]support failed task after connector restart#386sunheyi6 wants to merge 5 commits intoapache:masterfrom
Conversation
|
please fix compile error |
@odbozhou ok,already fixed. Isn't there some tool that automatically recognizes this formatting problem? |
https://rocketmq.apache.org/zh/docs/4.x/contributionGuide/30code-guidelines You can refer to this document, ide import checkstyle |
odbozhou
left a comment
There was a problem hiding this comment.
org.apache.rocketmq.connect.runtime.service.ConfigManagementServiceImpl.ConfigChangeCallback#onCompletion
Is it missing the processing of restart connector and task in ConfigChangeCallback#onCompletion?
.../src/main/java/org/apache/rocketmq/connect/runtime/controller/AbstractConnectController.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/rocketmq/connect/runtime/controller/AbstractConnectController.java
Outdated
Show resolved
Hide resolved
...ntime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementService.java
Outdated
Show resolved
Hide resolved
...ntime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementService.java
Outdated
Show resolved
Hide resolved
@odbozhou I have fixed the problem you mentioned, but how to stop the task, I still don't understand |
org.apache.rocketmq.connect.runtime.connectorwrapper.Worker#awaitStopTask The worker has provided related methods to wait for the stop task |
...va/org/apache/rocketmq/connect/runtime/service/memory/MemoryConfigManagementServiceImpl.java
Show resolved
Hide resolved
.../org/apache/rocketmq/connect/runtime/controller/distributed/TestConfigManagementService.java
Show resolved
Hide resolved
MemoryConfigManagementServiceImpl#restartTask
What is the purpose of the change
close #383
support failed task after connector restart
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.