Skip to content

RATIS-2518. Make testInstallSnapshotDuringBootstrap diagnostics fail-safe. #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slfan1989 wants to merge 1 commit into
base: RATIS-1931_grpc-zero-copy
Choose a base branch
from
+30 −9
Open

RATIS-2518. Make testInstallSnapshotDuringBootstrap diagnostics fail-safe. #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions ratis-server/src/test/java/org/apache/ratis/InstallSnapshotNotificationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,21 +613,42 @@ private void dumpClusterState(CLUSTER cluster, String phase, RaftPeer[] peersInN
+ "leaderSnapshotInfo={}\n{}\n{}",
phase, Arrays.asList(peersInNewConf), numSnapshotRequests.get(), numNotifyInstallSnapshotFinished.get(),
Optional.ofNullable(leaderSnapshotInfo).map(SnapshotInfo::getTermIndex).orElse(null),
cluster.printServers(), cluster.printAllLogs(), cause);
safeToString(cluster::printServers), safeToString(cluster::printAllLogs), cause);

for (RaftServer.Division division : cluster.iterateDivisions()) {
final SnapshotInfo snapshot = division.getStateMachine().getLatestSnapshot();
final SnapshotInfo snapshot = safeGet(() -> division.getStateMachine().getLatestSnapshot());
LOG.error("{}: divisionState id={}, role={}, leaderId={}, leaderReady={}, alive={}, term={}, "
+ "lastAppliedIndex={}, snapshot={}, logStartIndex={}, logNextIndex={}, commitIndex={}, conf={}, "
+ "followerNextIndices={}, followerMatchIndices={}",
phase, division.getId(), division.getInfo().getCurrentRole(), division.getInfo().getLeaderId(),
division.getInfo().isLeaderReady(), division.getInfo().isAlive(), division.getInfo().getCurrentTerm(),
division.getInfo().getLastAppliedIndex(),
phase, division.getId(), safeToString(() -> division.getInfo().getCurrentRole()),
safeToString(() -> division.getInfo().getLeaderId()),
safeToString(() -> division.getInfo().isLeaderReady()), safeToString(() -> division.getInfo().isAlive()),
safeToString(() -> division.getInfo().getCurrentTerm()), safeToString(() -> division.getInfo()
.getLastAppliedIndex()),
Optional.ofNullable(snapshot).map(SnapshotInfo::getTermIndex).orElse(null),
division.getRaftLog().getStartIndex(), division.getRaftLog().getNextIndex(),
division.getRaftLog().getLastCommittedIndex(), division.getRaftConf(),
Arrays.toString(division.getInfo().getFollowerNextIndices()),
Arrays.toString(division.getInfo().getFollowerMatchIndices()));
safeToString(() -> division.getRaftLog().getStartIndex()),
safeToString(() -> division.getRaftLog().getNextIndex()),
safeToString(() -> division.getRaftLog().getLastCommittedIndex()),
safeToString(division::getRaftConf),
safeToString(() -> Arrays.toString(division.getInfo().getFollowerNextIndices())),
safeToString(() -> Arrays.toString(division.getInfo().getFollowerMatchIndices())));
}
}

private static <T> T safeGet(Supplier<T> supplier) {
try {
return supplier.get();
} catch (RuntimeException e) {
LOG.warn("Failed to collect diagnostic state", e);
return null;
}
}

private static Object safeToString(Supplier<?> supplier) {
try {
return supplier.get();
} catch (RuntimeException e) {
return "unavailable: " + e;
}
}

Expand Down
Loading