Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private void runTests(InputStreamReader reader, String testName) {
RangerPluginContext pluginContext = new RangerPluginContext(new RangerPluginConfig(serviceType, null, "test-policy-acls", "cl1", "on-prem", policyEngineOptions));
RangerPolicyEngine policyEngine = new RangerPolicyEngineImpl(testCase.servicePolicies, pluginContext, null);

testCase.tests.parallelStream().filter(Objects::nonNull).forEach(oneTest -> {
testCase.tests.stream().filter(Objects::nonNull).forEach(oneTest -> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change it from parallelStream to stream. I’ve been investigating this and the parallel execution was an intentional change made as part of RANGER-5115.

We need more analysis to determine the correct fix for this test failure. The test only started failing a couple of hours ago in my local env, so I haven’t finished the root cause analysis yet.

If this is blocking, we can temporarily disable the test, but I recommend not modifying the test logic.

@ChinmayHegde24 If it’s urgent, please disable the test for now. We’ll analyze the failure and push a proper fix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyommani Sure , that will cause only issues in local build, in CI it's fine anyway so it'll not block there

RangerAccessRequestImpl request = new RangerAccessRequestImpl(oneTest.resource, RangerPolicyEngine.ANY_ACCESS, null, null, null);

request.setResourceMatchingScope(oneTest.resourceMatchingScope);
Expand Down
Loading