Skip to content

RANGER-5598:RangerHiveAuthorizer showprivileges should consider principal expiry condition in the GDS grants #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rameeshm wants to merge 1 commit into
base: master
Choose a base branch
from
+75 −10
Open

RANGER-5598:RangerHiveAuthorizer showprivileges should consider principal expiry condition in the GDS grants #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions ...t/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2608,7 +2608,7 @@ private List<HivePrivilegeInfo> getHivePrivilegeInfos(HivePrincipal principal, H
partValues = (msObjRef.getPartValues() == null) ? new ArrayList<>() : msObjRef.getPartValues();
hivePrivilegeObject = new HivePrivilegeObject(objectType, dbName, objectName);

RangerResourceACLs rangerResourceACLs = getRangerResourceACLs(hivePrivilegeObject);
RangerResourceACLs rangerResourceACLs = getRangerResourceACLs(hivePrivilegeObject, principal);

if (rangerResourceACLs != null) {
Map<String, Map<String, RangerResourceACLs.AccessResult>> userRangerACLs = rangerResourceACLs.getUserACLs();
Expand Down Expand Up @@ -2800,16 +2800,50 @@ private Set<String> getPrincipalGroup(String user) {
return Sets.newHashSet(ugi.getGroupNames());
}

private RangerResourceACLs getRangerResourceACLs(HivePrivilegeObject hiveObject) {
LOG.debug("==> RangerHivePolicyProvider.getRangerResourceACLs:[{}]", hiveObject);
private RangerResourceACLs getRangerResourceACLs(HivePrivilegeObject hiveObject, HivePrincipal principal) {
RangerResourceACLs ret = null;

RangerResourceACLs ret;
RangerHiveResource hiveResource = createHiveResource(hiveObject);
RangerAccessRequestImpl request = new RangerAccessRequestImpl(hiveResource, RangerPolicyEngine.ANY_ACCESS, null, null, null);
LOG.debug("==> RangerHivePolicyProvider.getRangerResourceACLs:[{}], principal=[{}]", hiveObject, principal);

RangerHiveResource hiveResource = createHiveResource(hiveObject);
if (hiveResource == null) {
return null;
}

RangerAccessRequestImpl request;
if (principal == null) {
request = new RangerAccessRequestImpl(hiveResource, RangerPolicyEngine.ANY_ACCESS, null, null, null);
} else {
String user = null;
Set<String> groups = Collections.emptySet();
Set<String> roles = Collections.emptySet();

switch (principal.getType()) {
case USER:
user = principal.getName();
groups = getPrincipalGroup(user);
roles = getCurrentRolesForUser(user, groups);
break;
case GROUP:
groups = Sets.newHashSet(principal.getName());
break;
case ROLE:
roles = Sets.newHashSet(principal.getName());
break;
default:
break;
}

if (LOG.isDebugEnabled()) {
LOG.debug("getRangerResourceACLs(): principalType={}, user={}, groups={}, roles={}", principal.getType(), user, groups, roles);
}

request = new RangerHiveAccessRequest(hiveResource, user, groups, roles, "SHOW PRIVILEGES", HiveAccessType.USE, null, null);
}

ret = hivePlugin.getResourceACLs(request);

LOG.debug("<== RangerHivePolicyProvider.getRangerResourceACLs:[{}], Computed ACLS:[{}]", hiveObject, ret);
LOG.debug("<== RangerHivePolicyProvider.getRangerResourceACLs:[{}], principal=[{}], Computed ACLS:[{}]", hiveObject, principal, ret);

return ret;
}
Expand Down
37 changes: 34 additions & 3 deletions ...c/test/java/org/apache/ranger/authorization/hive/authorizer/TestRangerHiveAuthorizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,13 +1279,44 @@ public void test65_getRangerResourceACLs_delegatesToPlugin() throws Exception {
Mockito.when(msFactory.getHiveMetastoreClient()).thenReturn(ms);

RangerHiveAuthorizer authorizer = new RangerHiveAuthorizer(msFactory, null, null, null);
Method m = RangerHiveAuthorizer.class.getDeclaredMethod("getRangerResourceACLs", HivePrivilegeObject.class);
Method m = RangerHiveAuthorizer.class.getDeclaredMethod("getRangerResourceACLs", HivePrivilegeObject.class, HivePrincipal.class);
m.setAccessible(true);
HivePrivilegeObject obj = new HivePrivilegeObject(HivePrivilegeObjectType.TABLE_OR_VIEW, "db1", "t1");
Object out = m.invoke(authorizer, obj);
HivePrivilegeObject obj = new HivePrivilegeObject(HivePrivilegeObjectType.TABLE_OR_VIEW, "db1", "t1");
HivePrincipal principal = new HivePrincipal("analyst", HivePrincipal.HivePrincipalType.ROLE);
Object out = m.invoke(authorizer, obj, principal);
assertInstanceOf(RangerResourceACLs.class, out);
}

@Test
void test66_getRangerResourceACLs_usesPrincipalContext() throws Exception {
RangerBasePlugin plugin = (RangerBasePlugin) Mockito.spy(newInstanceRangerHivePlugin("hiveCLI"));
Mockito.doReturn(new RangerResourceACLs()).when(plugin).getResourceACLs(Mockito.any(RangerAccessRequestImpl.class));
setStaticHivePlugin(plugin);

HiveMetastoreClientFactory msFactory = Mockito.mock(HiveMetastoreClientFactory.class);
IMetaStoreClient ms = Mockito.mock(IMetaStoreClient.class);
Mockito.when(msFactory.getHiveMetastoreClient()).thenReturn(ms);
RangerHiveAuthorizer authorizer = new RangerHiveAuthorizer(msFactory, null, null, null);

Method m = RangerHiveAuthorizer.class.getDeclaredMethod("getRangerResourceACLs", HivePrivilegeObject.class, HivePrincipal.class);
m.setAccessible(true);

HivePrivilegeObject obj = new HivePrivilegeObject(HivePrivilegeObjectType.TABLE_OR_VIEW, "db1", "t1");
HivePrincipal principal = new HivePrincipal("analyst", HivePrincipal.HivePrincipalType.ROLE);
m.invoke(authorizer, obj, principal);

Mockito.verify(plugin).getResourceACLs(Mockito.argThat(req -> {
if (!(req instanceof RangerHiveAccessRequest)) {
return false;
}
RangerHiveAccessRequest request = (RangerHiveAccessRequest) req;
return request.getUser() == null &&
request.getUserGroups().isEmpty() &&
request.getUserRoles().contains("analyst") &&
request.getHiveAccessType() == RangerHiveAuthorizer.HiveAccessType.USE;
}));
}

@Test
public void test67_getHivePrivilegeInfos_userPrincipal() throws Exception {
RangerBasePlugin plugin = (RangerBasePlugin) Mockito.spy(newInstanceRangerHivePlugin("hiveCLI"));
Expand Down
Loading