RANGER-5592: [GDS] Validity Period is not working for dataset policy#945
Open
maheshbandal15 wants to merge 2 commits into
Open
RANGER-5592: [GDS] Validity Period is not working for dataset policy#945maheshbandal15 wants to merge 2 commits into
maheshbandal15 wants to merge 2 commits into
Conversation
mneethiraj
reviewed
May 14, 2026
|
|
||
| policyEvaluators.forEach(e -> e.evaluate(datasetRequest, datasetResult)); | ||
| policyEvaluators.forEach(e -> { | ||
| if (!e.isApplicable(accessTime)) { |
Contributor
There was a problem hiding this comment.
For better readability, consider reversing the conition:
policyEvaluators.forEach(e -> {
if (e.isApplicable(accessTime)) {
e.evaluate(datasetRequest, datasetResult);
}
});
Also, this fix will be needed in GdsProjectEvaluator.evaluate() as well.
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing. I have addressed the review comment. Kindly review the updated patch.
RANGER-5597 is created to track required fix in GdsProjectEvaluator.evaluate(). Refer #946
mneethiraj
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed an issue where the GDS validity period was not enforced for dataset policies. Previously, when a dataset was configured with a validity end date set before the current date, users were still allowed to execute queries (e.g., SELECT) instead of being denied access. The validity period expiration is now correctly evaluated, ensuring that access through dataset policies is denied once the validity period has expired.
How was this patch tested?
Manual testing is done.
build successful with "mvn clean install"