Skip to content

RANGER-5435: Change the default KMS ZoneKey length from 128 to 256 #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikaskr22 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

RANGER-5435: Change the default KMS ZoneKey length from 128 to 256 #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ public class KMS {
private static final String KEY_NAME_VALIDATION = "[a-z,A-Z,0-9](?!.*--)(?!.*__)(?!.*-_)(?!.*_-)[\\w\\-\\_]*";
private static final int MAX_NUM_PER_BATCH = 10000;
private static final String GENERATE_DEK_PATH_CONST = "_dek";
private static final int DEFAULT_KEY_SIZE = 256;

private final KeyProviderCryptoExtension provider;
private final KMSAudit kmsAudit;
Expand Down Expand Up @@ -113,7 +114,7 @@ public Response createKey(Map jsonKey, @Context HttpServletRequest request) thro

final String cipher = (String) jsonKey.get(KMSRESTConstants.CIPHER_FIELD);
final String material = (String) jsonKey.get(KMSRESTConstants.MATERIAL_FIELD);
final int length = (jsonKey.containsKey(KMSRESTConstants.LENGTH_FIELD)) ? (Integer) jsonKey.get(KMSRESTConstants.LENGTH_FIELD) : 0;
final int length = (jsonKey.containsKey(KMSRESTConstants.LENGTH_FIELD)) ? (Integer) jsonKey.get(KMSRESTConstants.LENGTH_FIELD) : DEFAULT_KEY_SIZE;
final String description = (String) jsonKey.get(KMSRESTConstants.DESCRIPTION_FIELD);

LOG.debug("Creating key: name={}, cipher={}, keyLength={}, description={}", name, cipher, length, description);
Expand Down
2 changes: 1 addition & 1 deletion security-admin/src/main/java/org/apache/ranger/view/VXKmsKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public class VXKmsKey extends VXDataObject implements java.io.Serializable {
/**
* Length
*/
protected int length;
protected int length = 256;
/**
* Description
*/
Expand Down
2 changes: 1 addition & 1 deletion security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ function KeyCreate(props) {
initialValues={{
attributes: [{ name: "", value: "" }],
cipher: "AES/CTR/NoPadding",
length: "128"
length: "256"
}}
render={({
handleSubmit,
Expand Down
Loading