[fix][client] Avoid exception in ConsumerImpl hasMessageAvailable before first receive#25857
Open
void-ptr974 wants to merge 1 commit into
Open
[fix][client] Avoid exception in ConsumerImpl hasMessageAvailable before first receive#25857void-ptr974 wants to merge 1 commit into
void-ptr974 wants to merge 1 commit into
Conversation
a3d500b to
8d5b38d
Compare
8d5b38d to
75370b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25837
Motivation
ConsumerImpl.hasMessageAvailable()can throwUnsupportedOperationException: Unknown MessageId type: nullwhen it is called before any message has been dequeued from a consumer created throughnewConsumer().subscribe().hasMessageAvailableis not part of theConsumerpublic interface, butConsumerImplexposes it as a public implementation method. The publicReaderAPI also delegates itshasMessageAvailablemethods to the underlying consumer implementation. In the failing consumer state,startMessageIdcan benull, and the existing comparison path eventually callsMessageIdAdv.compareTo(null).Modifications
startMessageId == nullstate by querying the broker for the last message id response and comparing it with the subscription mark-delete position.FutureUtil.unwrapCompletionException(...)when propagating failures fromhasMessageAvailableAsync().ConsumerImplimplementation method, the publicReaderAPI path, and empty-topic behavior.Verifying this change
This change added tests and can be verified as follows:
SimpleProducerConsumerTest.testConsumerImplHasMessageAvailableDoesNotThrowBeforeReceive.SimpleProducerConsumerTest.testReaderHasMessageAvailableDoesNotThrowBeforeRead.SimpleProducerConsumerTest.testHasMessageAvailableDoesNotThrowOnEmptyTopic.Does this pull request potentially affect one of the following parts: