[fix][broker] Fix race condition in producer creation that causes flaky tests#25464
Closed
merlimat wants to merge 1 commit intoapache:masterfrom
Closed
[fix][broker] Fix race condition in producer creation that causes flaky tests#25464merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
…ky tests When a producer creation times out, the close command completes the producerFuture before buildProducerAndAddTopic runs. The producer still gets added to the topic briefly, blocking a subsequent producer with the same name. Fix by checking producerFuture.isDone() before calling topic.addProducer().
github-actions
bot
added
doc-label-missing
doc-not-needed
Contributor
Author
|
Fixed in #25460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ServerCnxTest.testCreateProducerTimeoutandtestCreateProducerTimeoutThenCreateSameNamedProducerShouldFailare flaky due to a race condition in the producer creation async chain.When a producer creation times out, the close command completes the
producerFuturebeforebuildProducerAndAddTopicruns. The producer still gets added to the topic briefly viatopic.addProducer(), blocking a subsequent producer with the same name from being created.Stack traces
Modifications
Add a
producerFuture.isDone()check inbuildProducerAndAddTopicbefore callingtopic.addProducer(). If the future was already completed (e.g. by a close/timeout), clean up and return early instead of registering the producer on the topic.Documentation
doc-not-needed