-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][broker]Part-2 of PIP-433 add validation when enabling namespace-level Geo-Replication #25170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…pace-level Geo-Replication
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
Denovo1998
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poorbarcode
1.Partition consistency verification is "one-way" (only starting from the local topic).
- The current logic will not detect the situation where "the remote already has a topic (and it may conflict with the local one in the future) but the local hasn't been created yet."
- The test does not cover the case where "topic only exists remotely and conflicts with local policy".
2.Performance risk: Calling getPartitionedTopicMetadataAsync remotely once for each topic under the namespace
Should we consider concurrency limiting (semaphore), batching, or state in the document/comments that this is an admin operation and may take time?
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
...ker/src/test/java/org/apache/pulsar/broker/service/SetReplicationClustersValidationTest.java
Outdated
Show resolved
Hide resolved
This is the biggest concern I have about this chance. |
Motivation
This is part-2 of PIP-433.
Modifications
Checks compatibility between two clusters when enabling namespace-level replication, which includes the following
Documentation
docdoc-requireddoc-not-neededdoc-complete