Skip to content

[improve][cli] Add client side looping in "pulsar-admin topics analyze-backlog" cli to avoid potential HTTP call timeout#25126

Open
oneby-wang wants to merge 21 commits intoapache:masterfrom
oneby-wang:pulsar_cli_client_side_analyze_backlog
Open

[improve][cli] Add client side looping in "pulsar-admin topics analyze-backlog" cli to avoid potential HTTP call timeout#25126
oneby-wang wants to merge 21 commits intoapache:masterfrom
oneby-wang:pulsar_cli_client_side_analyze_backlog

Conversation

@oneby-wang
Copy link
Copy Markdown
Contributor

Fixes #25083

Motivation

Use client-side looping instead of increasing broker settings to avoid potential HTTP call timeout in "pulsar-admin topics analyze-backlog" cli.

Modifications

Add client-side looping, add test.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: oneby-wang#21

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 6, 2026
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
@oneby-wang
Copy link
Copy Markdown
Contributor Author

oneby-wang commented Feb 5, 2026

@lhotari Could help me solve the above questions when you have a moment? Especially about how to write integration tests easily in admin CLI module.

I'll refactor this PR using the API that PR #25127 provided once I'm back.

@lhotari
Copy link
Copy Markdown
Member

lhotari commented Feb 6, 2026

@oneby-wang #25127 has been merged

@oneby-wang oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch from b48e0eb to 83bdbf1 Compare February 6, 2026 11:56
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
@oneby-wang oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch 3 times, most recently from 425e8bf to 941b50c Compare February 25, 2026 14:05
@oneby-wang oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch from 717742a to 91001d3 Compare March 28, 2026 03:58
@oneby-wang oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch from 91001d3 to 2456a05 Compare April 4, 2026 12:00
@oneby-wang oneby-wang requested a review from lhotari April 6, 2026 05:03
@oneby-wang
Copy link
Copy Markdown
Contributor Author

Hi @lhotari, could you please help review this refactored PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

2 participants