Skip to content

[improve][broker] Enhance logging for adding schema failures in ServerCnx #25048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coderzc merged 3 commits into from
Jan 5, 2026
+10 −3
Merged

[improve][broker] Enhance logging for adding schema failures in ServerCnx #25048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51b60cf
[improve][broker] Enhance logging for schema addition failures in Ser…
coderzc Dec 9, 2025
b8b3182
Ignore IncompatibleSchemaException
coderzc Dec 17, 2025
22fac66
[improve][broker] Enhance logging for invalid schema data in ServerCnx
coderzc Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
import org.apache.pulsar.broker.service.persistent.PersistentTopic;
import org.apache.pulsar.broker.service.schema.SchemaRegistryService;
import org.apache.pulsar.broker.service.schema.exceptions.IncompatibleSchemaException;
import org.apache.pulsar.broker.service.schema.exceptions.InvalidSchemaDataException;
import org.apache.pulsar.broker.topiclistlimit.TopicListMemoryLimiter;
import org.apache.pulsar.broker.topiclistlimit.TopicListSizeResultCache;
import org.apache.pulsar.broker.web.RestException;
Expand Down Expand Up @@ -1730,11 +1731,17 @@ protected void handleProducer(final CommandProducer cmdProducer) {
BrokerServiceException.getClientErrorCode(exception),
message);
}

var cause = FutureUtil.unwrapCompletionException(exception);
if (!(cause instanceof IncompatibleSchemaException)) {
if (cause instanceof IncompatibleSchemaException) {
// ignore it
} else if (cause instanceof InvalidSchemaDataException) {
log.warn("Try add schema failed due to invalid schema data, "
+ "remote address {}, topic {}, producerId {}",
remoteAddress, topicName, producerId);
} else {
log.error("Try add schema failed, remote address {}, topic {}, producerId {}",
remoteAddress,
topicName, producerId, exception);
remoteAddress, topicName, producerId, exception);
}
producers.remove(producerId, producerFuture);
return null;
Expand Down
Loading