Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Aug 26, 2025

Motivation

This setting supports building a Pulsar Functions base image that is used to run different Pulsar IO Kinesis
sink versions. The older versions of Pulsar IO Kinesis sink can continue to use the binary configured with
PULSAR_IO_KINESIS_KPL_PATH, pointing to a 0.15.12 native executable.
The newer versions of Pulsar IO Kinesis sink can use the binary configured with PULSAR_IO_KINESIS_KPL_1_0_PATH, pointing to a 1.0.4 native executable.

This use case is relevant for example in the case of Function Mesh base image. streamnative/function-mesh#820 is the PR that depends on this PR.

Kinesis Producer Library (KPL) was upgraded to 1.0.4 in PR #24661.

Modifications

Resolve the default nativeExecutable setting by first checking PULSAR_IO_KINESIS_KPL_1_0_PATH environment variable and then PULSAR_IO_KINESIS_KPL_PATH environment variable.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.23%. Comparing base (a239240) to head (ad5fb42).

Files with missing lines Patch % Lines
...rg/apache/pulsar/io/kinesis/KinesisSinkConfig.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #24669       +/-   ##
=============================================
+ Coverage     34.52%   74.23%   +39.71%     
- Complexity    12835    33196    +20361     
=============================================
  Files          1556     1885      +329     
  Lines        125763   146947    +21184     
  Branches      14379    16928     +2549     
=============================================
+ Hits          43415   109084    +65669     
+ Misses        76419    29161    -47258     
- Partials       5929     8702     +2773     
Flag Coverage Δ
inttests 26.63% <ø> (?)
systests 22.67% <0.00%> (?)
unittests 73.72% <50.00%> (+39.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rg/apache/pulsar/io/kinesis/KinesisSinkConfig.java 80.00% <50.00%> (ø)

... and 1537 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodece nodece merged commit 3b7bef1 into apache:master Aug 26, 2025
56 of 57 checks passed
lhotari added a commit that referenced this pull request Aug 26, 2025
…1.0 version specific path (#24669)

(cherry picked from commit 3b7bef1)
lhotari added a commit that referenced this pull request Aug 26, 2025
…1.0 version specific path (#24669)

(cherry picked from commit 3b7bef1)
lhotari added a commit that referenced this pull request Aug 26, 2025
…1.0 version specific path (#24669)

(cherry picked from commit 3b7bef1)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Aug 26, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 28, 2025
…1.0 version specific path (apache#24669)

(cherry picked from commit 3b7bef1)
(cherry picked from commit 41b9565)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 29, 2025
…1.0 version specific path (apache#24669)

(cherry picked from commit 3b7bef1)
(cherry picked from commit 0447713)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 3, 2025
…1.0 version specific path (apache#24669)

(cherry picked from commit 3b7bef1)
(cherry picked from commit 0447713)
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Sep 10, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 12, 2025
…1.0 version specific path (apache#24669)

(cherry picked from commit 3b7bef1)
(cherry picked from commit 41b9565)
nborisov pushed a commit to nborisov/pulsar that referenced this pull request Sep 12, 2025
…1.0 version specific path (apache#24669)

(cherry picked from commit 3b7bef1)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants