-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][io] Support specifying Kinesis KPL native binary path with 1.0 version specific path #24669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodece
merged 1 commit into
apache:master
from
lhotari:lh-support-multiple-kinesis-kpl-libs
Aug 26, 2025
Merged
[improve][io] Support specifying Kinesis KPL native binary path with 1.0 version specific path #24669
nodece
merged 1 commit into
apache:master
from
lhotari:lh-support-multiple-kinesis-kpl-libs
Aug 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.0 version specific path
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24669 +/- ##
=============================================
+ Coverage 34.52% 74.23% +39.71%
- Complexity 12835 33196 +20361
=============================================
Files 1556 1885 +329
Lines 125763 146947 +21184
Branches 14379 16928 +2549
=============================================
+ Hits 43415 109084 +65669
+ Misses 76419 29161 -47258
- Partials 5929 8702 +2773
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
approved these changes
Aug 26, 2025
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 26, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1) (cherry picked from commit 41b9565)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 29, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1) (cherry picked from commit 0447713)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 3, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1) (cherry picked from commit 0447713)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Sep 10, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1) (cherry picked from commit 41b9565)
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Sep 12, 2025
…1.0 version specific path (apache#24669) (cherry picked from commit 3b7bef1)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…1.0 version specific path (apache#24669)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…1.0 version specific path (apache#24669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.14
release/3.3.9
release/4.0.7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This setting supports building a Pulsar Functions base image that is used to run different Pulsar IO Kinesis
sink versions. The older versions of Pulsar IO Kinesis sink can continue to use the binary configured with
PULSAR_IO_KINESIS_KPL_PATH, pointing to a 0.15.12 native executable.The newer versions of Pulsar IO Kinesis sink can use the binary configured with
PULSAR_IO_KINESIS_KPL_1_0_PATH, pointing to a 1.0.4 native executable.This use case is relevant for example in the case of Function Mesh base image. streamnative/function-mesh#820 is the PR that depends on this PR.
Kinesis Producer Library (KPL) was upgraded to 1.0.4 in PR #24661.
Modifications
Resolve the default
nativeExecutablesetting by first checkingPULSAR_IO_KINESIS_KPL_1_0_PATHenvironment variable and thenPULSAR_IO_KINESIS_KPL_PATHenvironment variable.Documentation
docdoc-requireddoc-not-neededdoc-complete