Skip to content

Conversation

@visortelle
Copy link
Member

@visortelle visortelle commented Dec 23, 2023

To be properly listed on the projects.apache.org, the project must have a DOAP file. More info: https://projects.apache.org/create.html

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

The project has an entry here:
https://projects.apache.org/projects.html?name

but hasn't here: https://projects.apache.org/projects.html?language
and here: https://projects.apache.org/projects.html?category

@lhotari explained to me how to fix that here: https://lists.apache.org/thread/1q90j40vv6fb729fwlmc9npd6y2ws529

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: tealtools#3

To be listed on the projects.apache.org, the project must have a DOAP file.
More info: https://projects.apache.org/create.html
@visortelle
Copy link
Member Author

/pulsarbot rerun-failure-checks

@tisonkun
Copy link
Member

tisonkun commented Dec 26, 2023

/pulsarbot rerun-failure-checks

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may even skip running test for this file in .github/changes-filter.yaml

@visortelle
Copy link
Member Author

visortelle commented Dec 26, 2023

We may even skip running test for this file in .github/changes-filter.yaml

Probably, but it looks like an unnecessary micro-optimization to me.
Unlikely this file will be changed frequently.

@tisonkun
Copy link
Member

Yeah .. I just don't want to run test for this PR, lol.

Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Technoboy- Technoboy- added this to the 3.3.0 milestone Dec 26, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32f3577) 73.61% compared to head (e50d547) 73.61%.
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21796      +/-   ##
============================================
- Coverage     73.61%   73.61%   -0.01%     
+ Complexity    32885    32259     -626     
============================================
  Files          1898     1858      -40     
  Lines        140668   138021    -2647     
  Branches      15492    15111     -381     
============================================
- Hits         103559   101608    -1951     
+ Misses        29080    28561     -519     
+ Partials       8029     7852     -177     
Flag Coverage Δ
inttests 24.18% <ø> (-0.13%) ⬇️
systests 23.73% <ø> (-1.28%) ⬇️
unittests 72.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 144 files with indirect coverage changes

@tisonkun tisonkun merged commit b743f8f into apache:master Dec 26, 2023
@lhotari
Copy link
Member

lhotari commented Dec 26, 2023

I have registered the url to https://svn.apache.org/repos/asf/comdev/projects.apache.org/trunk/data/projects.xml
with this svn commit https://svn.apache.org/viewvc?view=revision&revision=1914938 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants