Skip to content

Conversation

@dave2wave
Copy link
Member

Fixes #20725

Motivation

Building the Docker image of Pulsar 2.11 was broken due to an incompatible wheel file. The wheel made on the manylinuz apachepulsar/pulsar-build image is compatible with Ubuntu 20.04, but is not compatible with Ubuntu 22.04.

Modifications

Reverting the changes to use Ubuntu 22.04 in Dockerfiles back to Ubuntu 20.04.
Added some print.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 8, 2023
@tisonkun
Copy link
Member

tisonkun commented Jul 8, 2023

I remember that we don't release Python client for 2.11. Shall we try to drop those code for an easier-to-maintain base?

cc @merlimat @BewareMyPower

@dave2wave dave2wave merged commit 5e3de72 into apache:branch-2.11 Jul 8, 2023
@dave2wave dave2wave deleted the force-wheel-to-3.8 branch July 8, 2023 17:56
@BewareMyPower
Copy link
Contributor

The wheel is installed from pip directly, with PULSAR_CLIENT_PYTHON_VERSION to specify the version.

pip3 install pulsar-client[all]==${PULSAR_CLIENT_PYTHON_VERSION}

I don't think we need much efforts to maintain it.

@BewareMyPower
Copy link
Contributor

Sorry I missed the fact that branch-2.11 still build code from source.

I think the issue is that when cherry-picking the original PR to branch-2.11, it didn't pin the Python client version to 3.2.0 so the build failed.

@RobertIndie
Copy link
Member

RobertIndie commented Jul 10, 2023

I think the issue is that when cherry-picking the original PR to branch-2.11, it didn't pin the Python client version to 3.2.0 so the build failed.

+1, we should cherry-pick the PR #20475 with changing the python client version to 3.2.0. Here is the root cause: #20475 (comment)

And there's a PR to fix it: #20770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants