Skip to content

Conversation

@michaeljmarshall
Copy link
Member

@michaeljmarshall michaeljmarshall commented Jun 1, 2023

Motivation

We want to keep the pulsar python functions using the latest library.

Modifications

  • Upgraded the python client version in the docker image

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)

Documentation

  • doc-not-needed

@michaeljmarshall michaeljmarshall added area/function area/dependency Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs labels Jun 1, 2023
@michaeljmarshall michaeljmarshall added this to the 3.1.0 milestone Jun 1, 2023
@michaeljmarshall michaeljmarshall self-assigned this Jun 1, 2023
@michaeljmarshall michaeljmarshall marked this pull request as ready for review June 7, 2023 18:54
@codecov-commenter
Copy link

Codecov Report

Merging #20467 (5fd09ff) into master (d7186a6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20467      +/-   ##
============================================
- Coverage     72.93%   72.93%   -0.01%     
+ Complexity    31930    31916      -14     
============================================
  Files          1867     1867              
  Lines        138555   138554       -1     
  Branches      15218    15218              
============================================
- Hits         101059   101054       -5     
- Misses        29466    29467       +1     
- Partials       8030     8033       +3     
Flag Coverage Δ
inttests 24.10% <100.00%> (-0.14%) ⬇️
systests 25.02% <100.00%> (+0.11%) ⬆️
unittests 72.22% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/apache/pulsar/broker/service/BrokerService.java 80.54% <ø> (-0.01%) ⬇️
...sar/broker/service/persistent/PersistentTopic.java 79.66% <100.00%> (+0.26%) ⬆️

... and 81 files with indirect coverage changes

@michaeljmarshall
Copy link
Member Author

superseded by #20475

@michaeljmarshall michaeljmarshall deleted the bump-python-client-version branch June 8, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Pull requests that update a dependency file area/function doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants