Fix possible zombie consumer when closing after reconnection #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mark it as drafted first, I think a better solution for seek after seek case is to add the backoff, which could be much simpler. I will improve this PR next week. |
Contributor
Author
|
@nodece This fix is ready, PTAL |
nodece
reviewed
Nov 5, 2025
BewareMyPower
added a commit
that referenced
this pull request
Nov 5, 2025
(cherry picked from commit 268aa4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
Motivation
When the consumer is during reconnection (e.g. after
seekis done), theSubscriberequest might be sent to the broker but the connection is not bound with the consumer. In this case,closeAsyncwon't send aCloseConsumerRPC because connection is not available, seepulsar-client-cpp/lib/ConsumerImpl.cc
Line 1355 in 3be5267
Modifications
After subscribed successfully, verifying the state is
PendingorReadybefore changing toReady. If not, send aCloseConsumerRPC to unregister the consumer. AddtestCloseAfterSeekto verify it's fixed.