Skip to content

Fix some compiler warnings in public headers #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 1 commit into from
Dec 26, 2024
Merged

Fix some compiler warnings in public headers #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

if (NOT MSVC)
set(CMAKE_C_FLAGS " -std=c99 ${CMAKE_C_FLAGS}")
add_compile_options(-Wextra -Wno-unused-parameter)
endif()

set(SAMPLE_ASYNC_PRODUCER_SOURCES
Expand Down
2 changes: 1 addition & 1 deletion include/pulsar/BrokerConsumerStats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class PULSAR_PUBLIC BrokerConsumerStats {
virtual const std::string getConnectedSince() const;

/** Returns Whether this subscription is Exclusive or Shared or Failover */
virtual const ConsumerType getType() const;
virtual ConsumerType getType() const;

/** Returns the rate of messages expired on this subscription. msg/s */
virtual double getMsgRateExpired() const;
Expand Down
2 changes: 1 addition & 1 deletion include/pulsar/Message.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class PULSAR_PUBLIC Message {
/**
* Get the redelivery count for this message
*/
const int getRedeliveryCount() const;
int getRedeliveryCount() const;

/**
* Check if schema version exists
Expand Down
4 changes: 2 additions & 2 deletions include/pulsar/c/client_configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,13 @@ PULSAR_PUBLIC const char *pulsar_client_configuration_get_listener_name(pulsar_c
PULSAR_PUBLIC void pulsar_client_configuration_set_partitions_update_interval(
pulsar_client_configuration_t *conf, const unsigned int intervalInSeconds);

PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_partitions_update_interval(
PULSAR_PUBLIC unsigned int pulsar_client_configuration_get_partitions_update_interval(
pulsar_client_configuration_t *conf);

/*
* Get the stats interval set in the client.
*/
PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
PULSAR_PUBLIC unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
pulsar_client_configuration_t *conf);

PULSAR_PUBLIC void pulsar_client_configuration_set_keep_alive_interval_in_seconds(
Expand Down
2 changes: 1 addition & 1 deletion lib/BrokerConsumerStats.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const std::string BrokerConsumerStats::getAddress() const { return impl_->getAdd

const std::string BrokerConsumerStats::getConnectedSince() const { return impl_->getConnectedSince(); }

const ConsumerType BrokerConsumerStats::getType() const { return impl_->getType(); }
ConsumerType BrokerConsumerStats::getType() const { return impl_->getType(); }

double BrokerConsumerStats::getMsgRateExpired() const { return impl_->getMsgRateExpired(); }

Expand Down
2 changes: 1 addition & 1 deletion lib/Message.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ const std::string& Message::getTopicName() const {
return impl_->getTopicName();
}

const int Message::getRedeliveryCount() const {
int Message::getRedeliveryCount() const {
if (!impl_) {
return 0;
}
Expand Down
6 changes: 2 additions & 4 deletions lib/c/c_ClientConfiguration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ void pulsar_client_configuration_set_stats_interval_in_seconds(pulsar_client_con
conf->conf.setStatsIntervalInSeconds(interval);
}

const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
pulsar_client_configuration_t *conf) {
unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(pulsar_client_configuration_t *conf) {
return conf->conf.getStatsIntervalInSeconds();
}

Expand Down Expand Up @@ -204,8 +203,7 @@ void pulsar_client_configuration_set_partitions_update_interval(pulsar_client_co
conf->conf.setPartititionsUpdateInterval(intervalInSeconds);
}

const unsigned int pulsar_client_configuration_get_partitions_update_interval(
pulsar_client_configuration_t *conf) {
unsigned int pulsar_client_configuration_get_partitions_update_interval(pulsar_client_configuration_t *conf) {
return conf->conf.getPartitionsUpdateInterval();
}

Expand Down
Loading