Fix topic name is shown as a pointer rather than string #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation This is an additional fix to apache#329 because I still observed logs like: ``` Closing consumer for topic 0x6000028e0648 Closing producer for topic 0x600001210b88 ``` It's because `HandlerBase::topic_` field is protected and could be accessed directly from the derived classes. ### Motivation In `HandlerBase`, make `topic_` private and add two methods `topic()` and `getTopicPtr()` to get the reference to the string and the shared pointer. `getTopicPtr()` should only be called when being passed to `MessageImpl::setTopicName`.
shibd
approved these changes
Oct 20, 2023
RobertIndie
approved these changes
Oct 20, 2023
BewareMyPower
added a commit
to streamnative/pulsar-client-cpp
that referenced
this pull request
Oct 20, 2023
### Motivation This is an additional fix to apache#329 because I still observed logs like: ``` Closing consumer for topic 0x6000028e0648 Closing producer for topic 0x600001210b88 ``` It's because `HandlerBase::topic_` field is protected and could be accessed directly from the derived classes. ### Motivation In `HandlerBase`, make `topic_` private and add two methods `topic()` and `getTopicPtr()` to get the reference to the string and the shared pointer. `getTopicPtr()` should only be called when being passed to `MessageImpl::setTopicName`. (cherry picked from commit 7cefe0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an additional fix to #329 because I still observed logs like:
It's because
HandlerBase::topic_field is protected and could be accessed directly from the derived classes.Motivation
In
HandlerBase, maketopic_private and add two methodstopic()andgetTopicPtr()to get the reference to the string and the shared pointer.getTopicPtr()should only be called when being passed toMessageImpl::setTopicName.