Fix the handler instance is expired when the connection is established #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation We observed some logs that showed the handler instance is expired when the connection is established after a reconnection: ``` HandlerBase Weak reference is not valid anymore ``` https://github.com/apache/pulsar-client-cpp/blob/b35ae1aa4b9834886c0889635de81834f9b2f774/lib/HandlerBase.cc#L92 ### Modifications Pass a `shared_ptr` instead of a `weak_ptr` in `HandlerBase::grabCnx` to ensure the `connectionOpened` or `connectionFailed` callback is called if `ClientImpl::getConnection` is called. We only need to pass a `weak_ptr` in `scheduleReconnection` to skip the reconnection if the handler is expired.
merlimat
approved these changes
Oct 4, 2023
merlimat
pushed a commit
to streamnative/pulsar-client-cpp
that referenced
this pull request
Oct 4, 2023
apache#323) We observed some logs that showed the handler instance is expired when the connection is established after a reconnection: ``` HandlerBase Weak reference is not valid anymore ``` https://github.com/apache/pulsar-client-cpp/blob/b35ae1aa4b9834886c0889635de81834f9b2f774/lib/HandlerBase.cc#L92 Pass a `shared_ptr` instead of a `weak_ptr` in `HandlerBase::grabCnx` to ensure the `connectionOpened` or `connectionFailed` callback is called if `ClientImpl::getConnection` is called. We only need to pass a `weak_ptr` in `scheduleReconnection` to skip the reconnection if the handler is expired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We observed some logs that showed the handler instance is expired when the connection is established after a reconnection:
pulsar-client-cpp/lib/HandlerBase.cc
Line 92 in b35ae1a
Modifications
Pass a
shared_ptrinstead of aweak_ptrinHandlerBase::grabCnxto ensure theconnectionOpenedorconnectionFailedcallback is called ifClientImpl::getConnectionis called. We only need to pass aweak_ptrinscheduleReconnectionto skip the reconnection if the handler is expired.