[improve] AuthAthenz supports Copper Argos #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Add the parameters
x509CertChainandcaCertto the ZTSClient.cc. If an X.509 certificate is passed as a parameter, it assumes Copper Argos is used and sets the X.509 certificate as a request parameter to ZTS and gets a RoleToken.Remove
tokenExpirationTimebecause it is not used for the RoleToken (which is sent to Pulsar Brokers and used for authentication) but for the PrincipalToken (which is only used to get the RoleToken from ZTS). Instead I addedminExpiryTimeandmaxExpiryTimeto control the expiry time of the RoleToken in the same way as Java/Go clients.Existing users of this plugin will not be affected by this change.
Verifying this change
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)