Skip to content

Conversation

@shustsud
Copy link
Contributor

@shustsud shustsud commented May 23, 2023

Motivation

Modifications

  • Add the parameters x509CertChain and caCert to the ZTSClient.cc. If an X.509 certificate is passed as a parameter, it assumes Copper Argos is used and sets the X.509 certificate as a request parameter to ZTS and gets a RoleToken.

  • Remove tokenExpirationTime because it is not used for the RoleToken (which is sent to Pulsar Brokers and used for authentication) but for the PrincipalToken (which is only used to get the RoleToken from ZTS). Instead I added minExpiryTime and maxExpiryTime to control the expiry time of the RoleToken in the same way as Java/Go clients.

  • Existing users of this plugin will not be affected by this change.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shustsud shustsud changed the title [improve] AuthAthenz supports Copper Argos [WIP][improve] AuthAthenz supports Copper Argos May 24, 2023
@shustsud shustsud changed the title [WIP][improve] AuthAthenz supports Copper Argos [improve] AuthAthenz supports Copper Argos May 25, 2023
Copy link
Contributor

@hrsakai hrsakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@massakam massakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants