Skip to content

Support specifying the C++ standard for some higher dependencies #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 3 commits into from
May 16, 2023
Merged

Support specifying the C++ standard for some higher dependencies #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8c1c0
Support specifying the C++ standard for some higher dependencies
BewareMyPower May 15, 2023
f856154
Fix the wrong dependency name
BewareMyPower May 16, 2023
1d7dd07
Add back the CMAKE_C_STANDARD
BewareMyPower May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci-pr-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,14 +267,15 @@ jobs:
uses: actions/checkout@v3

- name: Install dependencies
run: brew install openssl protobuf boost zstd snappy
run: brew install openssl protobuf boost zstd snappy googletest

- name: Configure (default)
shell: bash
run: |
# The latest GTest requires C++14
cmake \
-B ./build-macos \
-DBUILD_TESTS=OFF \
-DCMAKE_CXX_STANDARD=14 \
-S .

- name: Compile
Expand Down
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ find_package(Threads REQUIRED)
MESSAGE(STATUS "Threads library: " ${CMAKE_THREAD_LIBS_INIT})

set(Boost_NO_BOOST_CMAKE ON)
set(CMAKE_CXX_STANDARD 11)
if (NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 11)
endif ()
set(CMAKE_C_STANDARD 11)

# Compiler specific configuration:
Expand Down
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ If you want to build and run the tests, you need to install [GTest](https://gith

If you want to use `ClientConfiguration::setLogConfFilePath`, you need to install the [Log4CXX](https://logging.apache.org/log4cxx) and add CMake option `-DUSE_LOG4CXX=ON`.

The [dependencies.yaml](./dependencies.yaml) file provides the recommended dependency versions, while you can still build from source with other dependency versions. If a dependency requires a higher C++ standard, e.g. C++14, you can specify the standard like:

```bash
cmake . -DCMAKE_CXX_STANDARD=14
```

## Platforms

Pulsar C++ Client Library has been tested on:
Expand Down