Open
Conversation
Member
|
Thanks @emilygilberts! Could you describe in the PR text what kind of refactoring you have done? |
Using "real" private methods
Member
|
@SourceR85 womp womp :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the ES6 refactoring I changed some syntax, but didn't change any behaviour.
I split the changes into three commits:
modernize chekpointer with some ES6 syntax:
varwithconstcompareReplicationHistorycomparisonsobjecthasSessionIdmake
updateCheckpointclass method and class methods private:_updateCheckpointas private class method_updateTargetand_updateSourceprivaterewrite methods using
async/awaitand extractinitCheckpointDochelper fn:async/awaitwithtry catchblocks for all class methods_initCheckpointDoc(2 tiny syntax fixed slipped into this commit: )
comparisonsobject_updateCheckpoint