Skip to content

Revert apache#18579 #18590

Open
deepthi912 wants to merge 1 commit into
apache:masterfrom
deepthi912:deepthi/revert-18579-add-approach4
Open

Revert apache#18579 #18590
deepthi912 wants to merge 1 commit into
apache:masterfrom
deepthi912:deepthi/revert-18579-add-approach4

Conversation

@deepthi912
Copy link
Copy Markdown
Collaborator

@deepthi912 deepthi912 commented May 27, 2026

Reverts #18579: as per #18579 (comment)

…RAW forward index + separate dictionary (apache#18579)"

This reverts commit acf9d4f.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.83%. Comparing base (baccdcc) to head (9cebbb2).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...e/operator/dociditerators/SVScanDocIdIterator.java 0.00% 7 Missing ⚠️
...ava/org/apache/pinot/core/plan/FilterPlanNode.java 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (baccdcc) and HEAD (9cebbb2). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (baccdcc) HEAD (9cebbb2)
java-21 5 4
unittests1 1 0
unittests 2 1
temurin 5 4
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #18590       +/-   ##
=============================================
- Coverage     64.28%   36.83%   -27.45%     
+ Complexity     1137     1136        -1     
=============================================
  Files          3335     3335               
  Lines        205898   206007      +109     
  Branches      32129    32134        +5     
=============================================
- Hits         132355    75886    -56469     
- Misses        62894   123256    +60362     
+ Partials      10649     6865     -3784     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-21 36.83% <0.00%> (-27.45%) ⬇️
temurin 36.83% <0.00%> (-27.45%) ⬇️
unittests 36.83% <0.00%> (-27.45%) ⬇️
unittests1 ?
unittests2 36.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deepthi912 deepthi912 requested a review from Jackie-Jiang May 27, 2026 05:44
@deepthi912 deepthi912 force-pushed the deepthi/revert-18579-add-approach4 branch from 9cebbb2 to 3de82e7 Compare May 27, 2026 19:52
@deepthi912 deepthi912 changed the title Fallback to RawValueBasedRegexpLikePredicateEvaluator when Inverted/Sorted/Dictionary Forward index is not enabled Revert apache#18579 (per Jackie's review) May 27, 2026
@deepthi912 deepthi912 changed the title Revert apache#18579 (per Jackie's review) Revert apache#18579 May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants