Add auto-complete flag to LineageEntry#18584
Open
krishan1390 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18584 +/- ##
=========================================
Coverage 64.27% 64.27%
Complexity 1137 1137
=========================================
Files 3335 3335
Lines 205898 205905 +7
Branches 32129 32131 +2
=========================================
+ Hits 132333 132343 +10
+ Misses 62931 62912 -19
- Partials 10634 10650 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoCompleteLineageEntrytoLineageEntry. Defaultfalsepreserves the existing client-driven completion semantics (endReplaceSegments).true, the entry signals that an observer (e.g. a controller-side periodic task) is permitted to mark the entry completed automatically once allsegmentsToare ONLINE in the external view.SegmentLineageserialization is updated to be tolerant on read (accepts both 4-tuple legacy and 5-tuple new format) and conservative on write (emits a 5th element only when the flag istrue), so rolling upgrades and mixed-version controllers can co-exist.PinotHelixResourceManager's lineage state-transition sites (endReplaceSegments, two branches ofrevertReplaceSegments) preserve the flag when constructing the updated entry.Test plan
SegmentLineageTestto round-trip aLineageEntrywithautoCompleteLineageEntry=truethroughZNRecord.ZNRecordwritten by an older controller and asserts it parses with the flag defaulting tofalse.