Skip to content

Log per-op failures in ZkMultiWriteBuilder#18581

Open
krishan1390 wants to merge 1 commit into
apache:masterfrom
krishan1390:pr/zk-multi-write-logging
Open

Log per-op failures in ZkMultiWriteBuilder#18581
krishan1390 wants to merge 1 commit into
apache:masterfrom
krishan1390:pr/zk-multi-write-logging

Conversation

@krishan1390
Copy link
Copy Markdown
Contributor

Summary

When a multi-op ZK transaction fails, the rolled-up KeeperException does not tell the operator which op within the batch caused the failure. This adds per-op diagnostics so on a failed multi() we log, for each op in the batch, the path, the op type (create / set / delete / check), and the per-op result code from KeeperException.getResults().

  • No behavior change — purely observability.
  • Strengthens the existing testBadVersionAtomicRollback test to assert that KeeperException.getResults() is populated on failure (the precondition the new logging relies on).

Test plan

  • ./mvnw -pl pinot-common -am test -Dtest=ZkMultiWriteBuilderTest
  • Manual: trigger a BadVersionException against a live ZK and verify the new per-op log lines pinpoint the offender.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant