Log per-op failures in ZkMultiWriteBuilder#18581
Open
krishan1390 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a multi-op ZK transaction fails, the rolled-up
KeeperExceptiondoes not tell the operator which op within the batch caused the failure. This adds per-op diagnostics so on a failedmulti()we log, for each op in the batch, the path, the op type (create / set / delete / check), and the per-op result code fromKeeperException.getResults().testBadVersionAtomicRollbacktest to assert thatKeeperException.getResults()is populated on failure (the precondition the new logging relies on).Test plan
./mvnw -pl pinot-common -am test -Dtest=ZkMultiWriteBuilderTestBadVersionExceptionagainst a live ZK and verify the new per-op log lines pinpoint the offender.🤖 Generated with Claude Code