Avoid materializing the full bitmap for count aggregation with filter on column with inverted index#18543
Open
siddharthteotia wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18543 +/- ##
============================================
+ Coverage 63.75% 64.28% +0.53%
+ Complexity 1932 1126 -806
============================================
Files 3292 3311 +19
Lines 201470 203788 +2318
Branches 31316 31721 +405
============================================
+ Hits 128442 131001 +2559
+ Misses 62735 62289 -446
- Partials 10293 10498 +205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement Summary
InvertedIndexFilterOperator.getNumMatchingDocs()for single-value columns by replacing the materialized-union approach with a sum of per-dictId bitmap cardinalitieFunctional Testing
FastFilteredCountTest+FastFilteredCountMCTesttogether run 100 query cases hittingFastFilteredCountOperator → filterOperator.getNumMatchingDocs()on SV-indexed columns — all pass.Performance Testing
See BenchmarkInvertedIndexGetNumMatchingDocs
SV Results
dict cardinality = 1K
dict cardinality = 100K
dict cardinality = 1M
Note
getNumMatchingDocs() call (one call per segment hit by the filter). A typical query fans out multiple segments per server.MV Results (MV Implementation not changed in this PR but bench test has MV POC code)
Backwards Compatibility