Skip to content

Thread TlsSpec through batch ingestion job runners for mTLS support#17703

Draft
ilamhs wants to merge 4 commits intoapache:masterfrom
ilamhs:jobtlspec
Draft

Thread TlsSpec through batch ingestion job runners for mTLS support#17703
ilamhs wants to merge 4 commits intoapache:masterfrom
ilamhs:jobtlspec

Conversation

@ilamhs
Copy link
Contributor

@ilamhs ilamhs commented Feb 13, 2026

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. security

Summary

Batch ingestion jobs (standalone, Hadoop, Spark) now thread the job-level TlsSpec
through to controller API calls (getTableConfig, getSchema, segment push). This
enables mTLS client authentication when pushing segments to TLS-enabled controllers.

Changes

  • Resolve FileUploadDownloadClient from TlsSpec instead of using a static singleton,
    building an SSLContext with both KeyManager and TrustManager when configured
  • Thread TlsSpec to getTableConfig/getSchema calls across all job runners
  • Add KeyManager support to fetchUrl in SegmentGenerationUtils

Fixes #17702

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.61%. Comparing base (5be01ef) to head (1f74b18).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...he/pinot/segment/local/utils/SegmentPushUtils.java 0.00% 26 Missing ⚠️
...t/segment/local/utils/ConsistentDataPushUtils.java 0.00% 12 Missing ⚠️
...mon/segment/generation/SegmentGenerationUtils.java 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5be01ef) and HEAD (1f74b18). Click for more details.

HEAD has 24 uploads less than BASE
Flag BASE (5be01ef) HEAD (1f74b18)
java-21 5 2
unittests 4 2
temurin 10 4
java-11 5 2
unittests2 2 0
integration 6 2
integration1 2 0
custom-integration1 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17703      +/-   ##
============================================
- Coverage     63.25%   55.61%   -7.64%     
+ Complexity     1499      721     -778     
============================================
  Files          3174     2479     -695     
  Lines        190373   140479   -49894     
  Branches      29089    22379    -6710     
============================================
- Hits         120417    78134   -42283     
+ Misses        60619    55751    -4868     
+ Partials       9337     6594    -2743     
Flag Coverage Δ
custom-integration1 ?
integration 0.00% <ø> (-100.00%) ⬇️
integration1 ?
integration2 0.00% <ø> (ø)
java-11 55.56% <0.00%> (-7.66%) ⬇️
java-21 55.59% <0.00%> (-7.64%) ⬇️
temurin 55.61% <0.00%> (-7.64%) ⬇️
unittests 55.62% <0.00%> (-7.63%) ⬇️
unittests1 55.62% <0.00%> (-0.03%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SegmentPushUtils should respect TlsSpec from SegmentGenerationJobSpec

2 participants