Add termination checks to FunnelEventsFunctionEval and FunnelStepDurationStats#17700
Open
yashmayya wants to merge 1 commit intoapache:masterfrom
Open
Add termination checks to FunnelEventsFunctionEval and FunnelStepDurationStats#17700yashmayya wants to merge 1 commit intoapache:masterfrom
yashmayya wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17700 +/- ##
============================================
- Coverage 63.21% 63.19% -0.02%
Complexity 1499 1499
============================================
Files 3179 3179
Lines 190696 190703 +7
Branches 29151 29152 +1
============================================
- Hits 120544 120517 -27
- Misses 60777 60811 +34
Partials 9375 9375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yashmayya
force-pushed
the
more-funnel-termination-checks
branch
from
96d4688 to
f1b729a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #17692