Fix default HTTPS protocol to use HttpsSegmentFetcher#17675
Open
ilamhs wants to merge 1 commit intoapache:masterfrom
Open
Fix default HTTPS protocol to use HttpsSegmentFetcher#17675ilamhs wants to merge 1 commit intoapache:masterfrom
ilamhs wants to merge 1 commit intoapache:masterfrom
Conversation
The default segment fetcher for HTTPS protocol incorrectly returns HttpSegmentFetcher instead of HttpsSegmentFetcher. This means SSL configuration options in HttpsSegmentFetcher (including the renewable SSL context added in apache#17315) are never used for default HTTPS fetches. This change: - Adds a dedicated HTTPS_SEGMENT_FETCHER instance - Initializes it alongside other default fetchers - Returns it for HTTPS protocol in getSegmentFetcher() - Updates javadoc and test to reflect correct behavior
❌ 1 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
Author
|
Verified that the tests failures are independent of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default segment fetcher for HTTPS protocol incorrectly returns HttpSegmentFetcher instead of HttpsSegmentFetcher. This means SSL configuration options in HttpsSegmentFetcher (including the renewable SSL context added in #17315) are never used for default HTTPS fetches.
This change:
Instructions:
featurebugfixperformanceuibackward-incompatrelease-notes(**)(*) Other labels to consider:
testingdependenciesdockerkubernetesobservabilitysecuritycode-styleextension-pointrefactorcleanup(**) Use
release-noteslabel for scenarios like: