Skip to content

Rename DictionaryIndexConfig.getUseVarLengthDictionary to isUseVarLengthDictionary#17662

Merged
Jackie-Jiang merged 7 commits intoapache:masterfrom
rsrkpatwari1234:rsrkpatwari1234-rename
Feb 18, 2026
Merged

Rename DictionaryIndexConfig.getUseVarLengthDictionary to isUseVarLengthDictionary#17662
Jackie-Jiang merged 7 commits intoapache:masterfrom
rsrkpatwari1234:rsrkpatwari1234-rename

Conversation

@rsrkpatwari1234
Copy link
Copy Markdown
Contributor

@rsrkpatwari1234 rsrkpatwari1234 commented Feb 8, 2026

Rename the boolean getter in DictionaryIndexConfig from getUseVarLengthDictionary() to isUseVarLengthDictionary() to follow Java boolean getter naming.

Method rename only; no behavior or config format change.

refactor code-style backward-incompat

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.23%. Comparing base (4ef8e3e) to head (59e8d0f).

Files with missing lines Patch % Lines
...ocal/segment/index/loader/ForwardIndexHandler.java 0.00% 0 Missing and 1 partial ⚠️
...loader/defaultcolumn/BaseDefaultColumnHandler.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17662      +/-   ##
============================================
- Coverage     63.25%   63.23%   -0.02%     
- Complexity     1499     1500       +1     
============================================
  Files          3174     3174              
  Lines        190323   190323              
  Branches      29080    29080              
============================================
- Hits         120381   120350      -31     
- Misses        60606    60645      +39     
+ Partials       9336     9328       -8     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.20% <66.66%> (-0.01%) ⬇️
java-21 63.19% <66.66%> (-0.03%) ⬇️
temurin 63.23% <66.66%> (-0.02%) ⬇️
unittests 63.23% <66.66%> (-0.02%) ⬇️
unittests1 55.61% <0.00%> (-0.02%) ⬇️
unittests2 34.06% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rsrkpatwari1234
Copy link
Copy Markdown
Contributor Author

@Jackie-Jiang Requesting your review

@Jackie-Jiang Jackie-Jiang added incompatible index-spi Related to index SPI interfaces labels Feb 18, 2026
@Jackie-Jiang Jackie-Jiang merged commit 525a8d0 into apache:master Feb 18, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

index-spi Related to index SPI interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants