Skip to content

PHOENIX-7789: Fix Flappers in SlowestScanMetricsIT #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjeet006py wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −9
Open

PHOENIX-7789: Fix Flappers in SlowestScanMetricsIT #2396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions phoenix-core/src/it/java/org/apache/phoenix/monitoring/SlowestScanMetricsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ public void testAggregateQueryWithGroupByAndOrderBy() throws Exception {

@Test
public void testQueryOnCoveredIndex() throws Exception {
int topN = 2;
int topN = 3;
String tableName = generateUniqueName();
String indexName = generateUniqueName();
try (Connection conn = DriverManager.getConnection(getUrl())) {
Expand All @@ -669,8 +669,8 @@ public void testQueryOnCoveredIndex() throws Exception {
JsonArray slowestScanMetricsJsonArray = getSlowestScanMetricsJsonArray(rs);

int totalBroc = 0;
// Outer array has size 2 as the base table is salted so, salt bucket no. of parallel scans
// are generated and topN is 2.
// Outer array has size 3 as the base table is salted so, salt bucket no. of parallel scans
// are generated and topN is 3.
assertEquals(topN, slowestScanMetricsJsonArray.size());
for (int i = 0; i < topN; i++) {
JsonArray groupArray = slowestScanMetricsJsonArray.get(i).getAsJsonArray();
Expand All @@ -693,7 +693,7 @@ public void testQueryOnCoveredIndex() throws Exception {

@Test
public void testQueryOnUncoveredIndex() throws Exception {
int topN = 2;
int topN = 3;
String tableName = generateUniqueName();
String indexName = generateUniqueName();
try (Connection conn = DriverManager.getConnection(getUrl())) {
Expand All @@ -718,8 +718,8 @@ public void testQueryOnUncoveredIndex() throws Exception {
JsonArray slowestScanMetricsJsonArray = getSlowestScanMetricsJsonArray(rs);

int totalBroc = 0;
// Outer array has size 2 as the base table is salted so, salt bucket no. of parallel scans
// are generated and topN is 2.
// Outer array has size 3 as the base table is salted so, salt bucket no. of parallel scans
// are generated and topN is 3.
assertEquals(topN, slowestScanMetricsJsonArray.size());
for (int i = 0; i < topN; i++) {
JsonArray groupArray = slowestScanMetricsJsonArray.get(i).getAsJsonArray();
Expand Down Expand Up @@ -787,7 +787,7 @@ public void testQueryOnView() throws Exception {

@Test
public void testQueryOnViewIndex() throws Exception {
int topN = 2;
int topN = 3;
String tableName = generateUniqueName();
String viewName = generateUniqueName();
String viewIndexName = generateUniqueName();
Expand Down Expand Up @@ -816,8 +816,8 @@ public void testQueryOnViewIndex() throws Exception {
JsonArray slowestScanMetricsJsonArray = getSlowestScanMetricsJsonArray(rs);

int totalBroc = 0;
// Outer array has size 2 as the base table is salted so, salt bucket no. of parallel scans
// are generated and topN is 2.
// Outer array has size 3 as the base table is salted so, salt bucket no. of parallel scans
// are generated and topN is 3.
assertEquals(topN, slowestScanMetricsJsonArray.size());
for (int i = 0; i < topN; i++) {
JsonArray groupArray = slowestScanMetricsJsonArray.get(i).getAsJsonArray();
Expand Down