Fix EventSourcedBehaviorRetentionSpec non-determinism#2803
Open
He-Pin wants to merge 1 commit intoapache:mainfrom
Open
Fix EventSourcedBehaviorRetentionSpec non-determinism#2803He-Pin wants to merge 1 commit intoapache:mainfrom
He-Pin wants to merge 1 commit intoapache:mainfrom
Conversation
He-Pin
force-pushed
the
port-retention-spec-nondeterminism
branch
from
1d821b9 to
0bd0ff3
Compare
He-Pin
force-pushed
the
port-retention-spec-nondeterminism
branch
from
0bd0ff3 to
ff7dd0c
Compare
Split the second batch of 10 increments into smaller batches (3+3+4) with intermediate assertions after each batch. This ensures snapshot and delete signals are observed in the expected order, preventing flaky test failures caused by interleaving of async operations. Upstream: akka/akka-core@f38f8cce11 Cherry-picked from akka/akka-core v2.8.0, which is now Apache licensed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
He-Pin
force-pushed
the
port-retention-spec-nondeterminism
branch
from
ff7dd0c to
433bea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
EventSourcedBehaviorRetentionSpechad a non-deterministic test failure where event ordering was not properly awaited before assertions.Modification
Added
expectNoMessagecalls to ensure retention cycles complete before verifying results, eliminating race conditions in the test.Result
Eliminates flaky test failures in
EventSourcedBehaviorRetentionSpec.References
Notes
main(includes merged Harden EventSourcedBehaviorRetentionSpec #2794 Harden RetentionSpec and Add StatusReply.fromTry and fromTryKeepException factory methods #2796 StatusReply.fromTry).