Remove non-deterministic SnapshotSerializeSpec test case#2802
Open
He-Pin wants to merge 1 commit intoapache:mainfrom
Open
Remove non-deterministic SnapshotSerializeSpec test case#2802He-Pin wants to merge 1 commit intoapache:mainfrom
He-Pin wants to merge 1 commit intoapache:mainfrom
Conversation
Philippus
reviewed
Mar 28, 2026
persistence-testkit/src/test/scala/org/apache/pekko/persistence/testkit/CommonUtils.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for catching that, @Philippus! The |
He-Pin
force-pushed
the
port-snapshot-serialize-spec-fix
branch
from
ac1eae6 to
8c341c7
Compare
Remove the 'test snapshot events with RetentionCriteria after sending commands' test that was never deterministic — it sent all commands at once and expected snapshots in a specific order, but internal async processing made the interleaving non-deterministic. Also add LogCapturing to CommonUtils trait for better test diagnostics. Upstream: akka/akka-core@50372b37c5 Cherry-picked from akka/akka-core v2.8.0, which is now Apache licensed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
He-Pin
force-pushed
the
port-snapshot-serialize-spec-fix
branch
from
8c341c7 to
6ffb193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SnapshotSerializeSpec contained a test case that was non-deterministic due to timing-dependent serialization behavior.
Modification
Removed the flaky test case that could not be made deterministic without fundamentally changing the test approach.
Note: The unrelated
LogCapturingchange from the upstream commit was separated out per review feedback.Result
Reduces false CI failures from non-deterministic test behavior.
References