release: fix source tarball and Java verification paths#48
Merged
Conversation
|
One small doc clarity suggestion: the Java section first runs |
|
Nit: |
Contributor
Author
|
@XiaoHongbo-Hope Thanks, I have fixed. The Java verification section now explicitly says to run only the snippet for the current platform. I also updated the release guide wording to say the source archive is built from the committed Git tree. |
|
+1 |
XiaoHongbo-Hope
pushed a commit
that referenced
this pull request
May 30, 2026
* release: avoid macOS metadata in source tarball * release: fix Java verification native paths * docs: clarify release verification steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source release script used rsync and the platform tar command, which can include macOS filesystem metadata such as AppleDouble files, pax headers, and com.apple.* extended attributes in the source tarball.
This PR generates the source archive from the committed Git tree with git archive and gzip -n, avoiding filesystem metadata in the release tarball.
The release verification guide also copied the JNI library into java/src/main/resources/native/, but NativeLib loads libraries from /native/{os}/{arch}/. This PR updates the guide to copy each platform library into the directory layout used by NativeLib and the Java release workflow.