Skip to content

HDDS-14885. Replace usage of Hadoop ...TestUtils#9966

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-14885
Mar 24, 2026
Merged

HDDS-14885. Replace usage of Hadoop ...TestUtils#9966
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-14885

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Replace usage of Hadoop's test utils (only affects contract tests) with regular assertions and Ozone's GenericTestUtils.

Remove exclusion of contract tests for banned imports.

https://issues.apache.org/jira/browse/HDDS-14885

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/23438883833/job/68188446350

@adoroszlai adoroszlai self-assigned this Mar 23, 2026
Copy link
Contributor

@spacemonkd spacemonkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @adoroszlai.
LGTM, +1.

new LambdaTestUtils.ProportionalRetryInterval(
CONSISTENCY_INTERVAL,
consistencyDelay));
GenericTestUtils.waitFor(() -> verifyFileLength(file, size2),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max wait time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistencyDelay

@adoroszlai adoroszlai merged commit fe80c6f into apache:master Mar 24, 2026
45 checks passed
@adoroszlai
Copy link
Contributor Author

Thanks @spacemonkd, @yandrey321 for the review.

@adoroszlai adoroszlai deleted the HDDS-14885 branch March 24, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants