HDDS-14874. Make Ratis append-entries.compose.enabled false by default.#9963
Open
ss77892 wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14874. Make Ratis append-entries.compose.enabled false by default.#9963ss77892 wants to merge 1 commit intoapache:masterfrom
ss77892 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-14874. Make Ratis append-entries.compose.enabled false by default.
Please describe your PR in detail:
RATIS-2235 has introduced performance degradation in Ozone. That was addressed in RATIS-2387, which made the previous logic optional. We should explicitly set append-entries.compose.enabled to false to restore the old behavior.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14874
How was this patch tested?
UTs.
Performance comparison of large file writes on 3 container-based nodes:
40GB file upload.
Before patch:
Run 1: Upload: 189.79s ( 215.81 MB/s)
Run 2: Upload: 178.98s ( 228.84 MB/s)
Run 3: Upload: 173.18s ( 236.51 MB/s)
After patch:
Run 1: Upload: 121.48s ( 337.16 MB/s)
Run 2: Upload: 122.66s ( 333.93 MB/s)
Run 3: Upload: 106.20s ( 385.67 MB/s)