HDDS-14858. OM request fails with ClassNotFoundException: java.lang.constant.Constable

[adoroszlai]

What changes were proposed in this pull request?

Running Ozone 2.1.0 (from release binaries) with JDK 11 or lower, key put (and probably some other requests) results in:

RemoteException: java/lang/constant/Constable
	at org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerRatisUtils.createClientRequest(OzoneManagerRatisUtils.java:353)
...
Caused by: java.lang.ClassNotFoundException: java.lang.constant.Constable

ozone/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java

Line 353 in de24a1a

return BucketLayoutAwareOMKeyRequestFactory.createRequest(

Constable is introduced in JDK 12, and it appears (at least) in BucketLayoutAwareOMKeyRequestFactory.

javap -verbose hadoop-ozone/ozone-manager/target/classes/org/apache/hadoop/ozone/om/request/BucketLayoutAwareOMKeyRequestFactory.class | grep Constable
  #324 = Class              #325          // java/lang/constant/Constable
  #325 = Utf8               java/lang/constant/Constable
          stack = [ class java/lang/StringBuilder, class java/lang/constant/Constable ]

This PR sets aspectj-maven-plugin's release property

to make sure that not only the generated byte code conforms to the target level but also the code is compiled against a specific JDK's API

Profile is created to set release, because aspectj-maven-plugin, unlike maven-compiler-plugin, does not support using it with Java 8.

https://issues.apache.org/jira/browse/HDDS-14858

How was this patch tested?

Checked (as described above) that BucketLayoutAwareOMKeyRequestFactory does not have reference to Constable.

CI:
https://github.com/adoroszlai/ozone/actions/runs/23246182813

[errose28]

Functionality LGTM assuming we are not supporting JDK 9 or 10, which I think is the case based on our CI matrix. It looks like there could be a corner case when building with Java 9 or 10 since it will activate the java9+ profile to set the release flag, but fall back to the default aspectj version of 1.9.7 which isn't overridden until Java 11. According to the aspectj docs:

Please note that before AspectJ 1.9.8.M1, the --release N compiler option was not working correctly.

[adoroszlai]

Thanks @errose28 for the review.

Please note that before AspectJ 1.9.8.M1, the --release N compiler option was not working correctly.

1.9.8 requires Java 11, so there is no version where --release "works correctly" with Java 9/10. Updated the profile to activate only with 11+.