HDDS-14490. HadoopRpcOMFollowerProxyProvider should explicitly use OzoneManagerProtocolPB #9670
+43
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oneManagerProtocolPB
adoroszlai
reviewed
Jan 28, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ivandika3 for the patch.
| @@ -107,32 +95,25 @@ public HadoopRpcOMFollowerReadFailoverProxyProvider(String omServiceId, Class<T> | |||
| .map(a -> a.proxyInfo) | |||
| .reduce((a, b) -> a + ", " + b).orElse("") + "]"; | |||
| @SuppressWarnings("unchecked") | |||
Contributor
There was a problem hiding this comment.
Suppression is no longer needed.
Contributor
There was a problem hiding this comment.
nit (not introduced in this patch): This is currently unused. Is this going to change in follow-up or can be removed?
Contributor
Author
There was a problem hiding this comment.
Let's remove this first. We can add this when we need it.
Comment on lines
64
to
65
| @VisibleForTesting | ||
| public static final Logger LOG = LoggerFactory.getLogger(HadoopRpcOMFollowerReadFailoverProxyProvider.class); |
Contributor
There was a problem hiding this comment.
nit (not introduced in this patch): this can be private and annotation removed.
| public HadoopRpcOMFollowerReadFailoverProxyProvider(String omServiceId, Class<T> protocol, | ||
| HadoopRpcOMFailoverProxyProvider<T> failoverProxy) { | ||
| this.protocolClass = protocol; | ||
| public HadoopRpcOMFollowerReadFailoverProxyProvider(String omServiceId, |
Contributor
There was a problem hiding this comment.
nit: omServiceId is unused
szetszwo
approved these changes
Jan 28, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since HadoopRpcOMFollowerReadFailoverProxyProvider handles only submitRequest from OzoneManagerProtocolPB, we should simply make it to only handle OzoneManagerProtocolPB.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14490
How was this patch tested?
CI (https://github.com/ivandika3/ozone/actions/runs/21347454675)