-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value #9622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sreejasahithi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Russole for fixing this,
LGTM
sarvekshayr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Russole for the fix.
The description is about invoking a script, which is specific to ScriptBasedMapping, not TableMapping.
|
Thanks @sarvekshayr for identifying the description mismatch , @Russole please update the description. |
|
Thanks @sreejasahithi and @sarvekshayr for the review. I’ve updated the patch based on the comments. |
|
actually according to https://issues.apache.org/jira/browse/HDDS-14385
|
|
Thanks @jojochuang for pointing this out. |
|
Instead, could you update the source code to make it consistent and understandable? Line 729 in fd89481
ozone/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java Line 365 in 1dda9ab
update it so the default is ScriptBasedMapping |
What changes were proposed in this pull request?
net.topology.node.switch.mapping.implinozone-default.xmlorg.apache.hadoop.net.TableMappingto match the actual behavior of OM and SCMWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14385
How was this patch tested?
All CI checks passed.
https://github.com/Russole/ozone/actions/runs/20881195253