HDDS-13921. Conditional Copy (CopyObject)#10207
HDDS-13921. Conditional Copy (CopyObject)#10207YutaLin wants to merge 7 commits intoapache:masterfrom
Conversation
|
Hi @ivandika3, @peterxcli |
peterxcli
left a comment
There was a problem hiding this comment.
LGTM. Could you also add s3 sdk v1/v2 test?
|
Hi @peterxcli, thanks for the review! |
peterxcli
left a comment
There was a problem hiding this comment.
@YutaLin I think this patch only handle the read side condition check, but we also need dest side:
Destination Object Conditions (AWS Release 2.37.0):
If-None-Match: "*" - Copy only if destination does NOT exist Prevents unintended overwrites of destination object
Error Codes: 412 Precondition Failed - When any condition is not met
| * @param sourceKey the source key metadata | ||
| * @throws OS3Exception with 412 Precondition Failed if conditions are not met | ||
| */ | ||
| static void evaluateCopySourcePreconditions(HttpHeaders headers, |
There was a problem hiding this comment.
could you try to reuse the evaluateReadPreconditions?
Hi @peterxcli, the conditional read side check is Let me know if I miss anything, thanks! |
What changes were proposed in this pull request?
support CopyObject conditions include
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13921
How was this patch tested?
add conditional copy object test and run action ci (https://github.com/YutaLin/ozone/actions/runs/25467526822)