Skip to content

ORC-1940: Add threads dependency to orc lib in Meson #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WillAyd wants to merge 1 commit into from
Closed

ORC-1940: Add threads dependency to orc lib in Meson #2301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions c++/src/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ source_files += files(

incdir = include_directories('../include')
orc_format_proto_dep = dependency('orc_format_proto')
# zstd requires us to add the threads
threads_dep = dependency('threads')
Copy link
Member

@wgtmac wgtmac Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work on Windows? Or does Meson support Windows?

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.

BTW, FYI, we lost Windows test coverage recently due to the EOL of Windows 2019.

Copy link
Contributor Author

@WillAyd WillAyd Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this works across platforms

Copy link
Contributor Author

@WillAyd WillAyd Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangentially we can look to add Meson CI for Windows. Typically the hardest part for Windows is getting the export macros correct, but if that's already taken care of it should be a trivial amount of effort

Copy link
Member

@wgtmac wgtmac Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun Thanks for the info! It seems that we need to bump version of protobuf to make the Windows 2025 CI happy.

@WillAyd It may or may not work out of box. But I think we can postpone this until required to do.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do you mean this which requires ORC 3.0.0 or something else, @wgtmac ?

Copy link
Member

@wgtmac wgtmac Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so.


orc_lib = library(
'orc',
Expand All @@ -184,6 +186,7 @@ orc_lib = library(
snappy_dep,
lz4_dep,
zstd_dep,
threads_dep,
],
include_directories: incdir,
install: true,
Expand Down
Loading