-
Notifications
You must be signed in to change notification settings - Fork 360
Address bug #126768 #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address bug #126768 #402
Conversation
…ner'' context. Addresses bug #126768
|
Looks great! |
|
The document attached to bug 126768 was crashing on Windows. The reason was an out-of-bound access in the This PR is IMHO ready to be merged. |
FYI the document also failed to open on Linux. Should I Merge it now? Or is it up to you to do that? |
|
I will try a new build now! Builds fine and I could open the files without problem now! LGTM! |
|
Funny fact: After saving the files with this version, I can also open them with AOO 4.1.16. |
|
Thank you for testing! |
|
If only we could cherry-pick it for AOO42X and release it... ;-) |
|
I am doing a Windows build to validate these commits on AOO42X. I hope I will be able to push them in 1-2 days. |
Bug report: https://bz.apache.org/ooo/show_bug.cgi?id=126768
Applying values of the
<svg:title>and<svg:desc>elements was failing due to the type of theSwXFrame'sSwModify::pRegisteredInattribute.A ``winner'' image is set its name successfully. Setting the above values to the same winner image also succeeds.
This PR must be checked against document with images, and hyperlinks as well.