Skip to content

Conversation

@ardovm
Copy link
Contributor

@ardovm ardovm commented Aug 30, 2025

Bug report: https://bz.apache.org/ooo/show_bug.cgi?id=126768

Applying values of the <svg:title> and <svg:desc> elements was failing due to the type of the SwXFrame's SwModify::pRegisteredIn attribute.
A ``winner'' image is set its name successfully. Setting the above values to the same winner image also succeeds.

This PR must be checked against document with images, and hyperlinks as well.

@Pilot-Pirx
Copy link
Member

Looks great!
Maybe we can get it into 4.1.16-RC1?

@ardovm
Copy link
Contributor Author

ardovm commented Dec 6, 2025

The document attached to bug 126768 was crashing on Windows. The reason was an out-of-bound access in the vcl library, that was only detectable after merging the commit in pr #450

This PR is IMHO ready to be merged.

@pedlino
Copy link
Contributor

pedlino commented Dec 6, 2025

The document attached to bug 126768 was crashing on Windows. The reason was an out-of-bound access in the vcl library, that was only detectable after merging the commit in pr #450

This PR is IMHO ready to be merged.

FYI the document also failed to open on Linux. Should I Merge it now? Or is it up to you to do that?

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Dec 6, 2025

I will try a new build now!

Builds fine and I could open the files without problem now!

LGTM!

@Pilot-Pirx
Copy link
Member

Pilot-Pirx commented Dec 7, 2025

Funny fact: After saving the files with this version, I can also open them with AOO 4.1.16.
Re-saving them with LO 25.8 makes them unreadable again with AOO 4.1.16.

@ardovm
Copy link
Contributor Author

ardovm commented Dec 8, 2025

Thank you for testing!
At least, we have a proof that AOO can re-read its own output ;-)

@ardovm ardovm merged commit 44f2bcd into trunk Dec 8, 2025
1 check passed
@ardovm ardovm deleted the bug126768 branch December 8, 2025 14:45
@Pilot-Pirx
Copy link
Member

If only we could cherry-pick it for AOO42X and release it... ;-)

@ardovm
Copy link
Contributor Author

ardovm commented Dec 8, 2025

I am doing a Windows build to validate these commits on AOO42X. I hope I will be able to push them in 1-2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants