Skip to content

services/pcloud: add digest auth, recursive listing, and read-path caching #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mro68 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

services/pcloud: add digest auth, recursive listing, and read-path caching #7617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e519229
fix(services/pcloud): use digest authentication
mro68 May 18, 2026
b7897de
feat(services/pcloud): support recursive listing
mro68 May 18, 2026
e98f274
fix(services/pcloud): keep absolute paths in recursive listing
mro68 May 19, 2026
bc35c51
perf(services/pcloud): cache ids and download links
mro68 May 19, 2026
327af1c
fix(services/pcloud): update copy access signature
mro68 May 25, 2026
dc21ffd
Merge branch 'main' into feat/opendal-pcloud-20260518
mro68 May 25, 2026
76ebc93
style(services/pcloud): format files with rustfmt
mro68 May 25, 2026
25c5918
Merge branch 'main' into feat/opendal-pcloud-20260518
mro68 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions core/services/pcloud/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ log = { workspace = true }
opendal-core = { path = "../../core", version = "0.57.0", default-features = false }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
sha1 = "0.10.6"

[dev-dependencies]
tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }
68 changes: 44 additions & 24 deletions core/services/pcloud/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,39 +135,42 @@ impl Builder for PcloudBuilder {
.with_context("service", PCLOUD_SCHEME)),
}?;

Ok(PcloudBackend {
core: Arc::new(PcloudCore {
info: {
let am = AccessorInfo::default();
am.set_scheme(PCLOUD_SCHEME)
.set_root(&root)
.set_native_capability(Capability {
stat: true,
let info = {
let am = AccessorInfo::default();
am.set_scheme(PCLOUD_SCHEME)
.set_root(&root)
.set_native_capability(Capability {
stat: true,

create_dir: true,

create_dir: true,
read: true,

read: true,
write: true,

write: true,
delete: true,
rename: true,
copy: true,

delete: true,
rename: true,
copy: true,
list: true,
list_with_recursive: true,

list: true,
shared: true,

shared: true,
..Default::default()
});

..Default::default()
});
am.into()
};

am.into()
},
Ok(PcloudBackend {
core: Arc::new(PcloudCore::new(
info,
root,
endpoint: self.config.endpoint.clone(),
self.config.endpoint.clone(),
username,
password,
}),
)),
})
}
}
Expand Down Expand Up @@ -213,6 +216,9 @@ impl Access for PcloudBackend {
}

if let Some(md) = resp.metadata {
if let Some(file_id) = md.fileid {
self.core.cache_file_id(path, file_id);
}
let md = parse_stat_metadata(md);
return md.map(RpStat::new);
}
Expand Down Expand Up @@ -258,8 +264,8 @@ impl Access for PcloudBackend {
))
}

async fn list(&self, path: &str, _args: OpList) -> Result<(RpList, Self::Lister)> {
let l = PcloudLister::new(self.core.clone(), path);
async fn list(&self, path: &str, args: OpList) -> Result<(RpList, Self::Lister)> {
let l = PcloudLister::new(self.core.clone(), path, args.recursive());
Ok((RpList::default(), oio::PageLister::new(l)))
}

Expand Down Expand Up @@ -293,6 +299,12 @@ impl Access for PcloudBackend {
return Err(Error::new(ErrorKind::Unexpected, format!("{resp:?}")));
}

if from.ends_with('/') {
self.core.invalidate_path_prefix_cache(to);
} else {
self.core.invalidate_path_cache(to);
}

Ok((RpCopy::default(), ()))
}
_ => Err(parse_error(resp)),
Expand Down Expand Up @@ -323,6 +335,14 @@ impl Access for PcloudBackend {
return Err(Error::new(ErrorKind::Unexpected, format!("{resp:?}")));
}

if from.ends_with('/') {
self.core.invalidate_path_prefix_cache(from);
self.core.invalidate_path_prefix_cache(to);
} else {
self.core.invalidate_path_cache(from);
self.core.invalidate_path_cache(to);
}

Ok(RpRename::default())
}
_ => Err(parse_error(resp)),
Expand Down
Loading
Loading