Skip to content

feat(metrics): add operation label to a few backends [1/N] #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dentiny wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(metrics): add operation label to a few backends [1/N] #7530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e61b3
feat(metrics): add operation label to a few backends
dentiny May 15, 2026
0793482
trigger ci
dentiny May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions core/services/azfile/src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ impl AzfileCore {
req = req.header(RANGE, range.to_header());
}

let req = req.extension(Operation::Read);
let req = req
.extension(Operation::Read)
.extension(ServiceOperation("GetFile"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -150,7 +152,9 @@ impl AzfileCore {
}
}

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("CreateFile"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -186,7 +190,9 @@ impl AzfileCore {
BytesRange::from(position..position + size).to_header(),
);

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("PutRange"));

let req = req.body(body).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand All @@ -204,7 +210,9 @@ impl AzfileCore {

let req = Request::head(&url);

let req = req.extension(Operation::Stat);
let req = req
.extension(Operation::Stat)
.extension(ServiceOperation("GetFileProperties"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand All @@ -223,7 +231,9 @@ impl AzfileCore {

let req = Request::head(&url);

let req = req.extension(Operation::Stat);
let req = req
.extension(Operation::Stat)
.extension(ServiceOperation("GetDirectoryProperties"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -275,7 +285,9 @@ impl AzfileCore {

req = req.header(X_MS_FILE_RENAME_REPLACE_IF_EXISTS, "true");

let req = req.extension(Operation::Rename);
let req = req
.extension(Operation::Rename)
.extension(ServiceOperation("Rename"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand All @@ -298,7 +310,9 @@ impl AzfileCore {

req = req.header(CONTENT_LENGTH, 0);

let req = req.extension(Operation::CreateDir);
let req = req
.extension(Operation::CreateDir)
.extension(ServiceOperation("CreateDirectory"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand All @@ -319,7 +333,9 @@ impl AzfileCore {

let req = Request::delete(&url);

let req = req.extension(Operation::Delete);
let req = req
.extension(Operation::Delete)
.extension(ServiceOperation("DeleteFile"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand All @@ -340,7 +356,9 @@ impl AzfileCore {

let req = Request::delete(&url);

let req = req.extension(Operation::Delete);
let req = req
.extension(Operation::Delete)
.extension(ServiceOperation("DeleteDirectory"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -379,7 +397,9 @@ impl AzfileCore {

let req = Request::get(url.finish());

let req = req.extension(Operation::List);
let req = req
.extension(Operation::List)
.extension(ServiceOperation("ListDirectoriesAndFiles"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down
36 changes: 28 additions & 8 deletions core/services/cos/src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ impl CosCore {
req = req.header(IF_UNMODIFIED_SINCE, if_unmodified_since.format_http_date());
}

let req = req.extension(Operation::Read);
let req = req
.extension(Operation::Read)
.extension(ServiceOperation("GetObject"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;

Expand Down Expand Up @@ -201,7 +203,9 @@ impl CosCore {
}
}

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("PutObject"));

let req = req.body(body).map_err(new_request_build_error)?;

Expand Down Expand Up @@ -242,7 +246,9 @@ impl CosCore {
req = req.header(IF_NONE_MATCH, if_none_match);
}

let req = req.extension(Operation::Stat);
let req = req
.extension(Operation::Stat)
.extension(ServiceOperation("HeadObject"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;

Expand All @@ -268,7 +274,9 @@ impl CosCore {

let req = Request::delete(&url);

let req = req.extension(Operation::Delete);
let req = req
.extension(Operation::Delete)
.extension(ServiceOperation("DeleteObject"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -308,7 +316,9 @@ impl CosCore {
req = req.header(CACHE_CONTROL, cache_control)
}

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("AppendObject"));

let req = req.body(body).map_err(new_request_build_error)?;
Ok(req)
Expand All @@ -328,6 +338,7 @@ impl CosCore {

let mut req = Request::put(&url)
.extension(Operation::Copy)
.extension(ServiceOperation("CopyObject"))
.header("x-cos-copy-source", &source);

// For a bucket which has never enabled versioning, x-cos-forbid-overwrite
Expand Down Expand Up @@ -371,6 +382,7 @@ impl CosCore {

let req = Request::get(url.finish())
.extension(Operation::List)
.extension(ServiceOperation("ListObjects"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down Expand Up @@ -409,7 +421,9 @@ impl CosCore {
}
}

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("InitiateMultipartUpload"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -438,7 +452,9 @@ impl CosCore {
let mut req = Request::put(&url);
req = req.header(CONTENT_LENGTH, size);

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("UploadPart"));

// Set body
let req = req.body(body).map_err(new_request_build_error)?;
Expand Down Expand Up @@ -471,7 +487,9 @@ impl CosCore {
// Set content-type to `application/xml` to avoid mixed with form post.
let req = req.header(CONTENT_TYPE, "application/xml");

let req = req.extension(Operation::Write);
let req = req
.extension(Operation::Write)
.extension(ServiceOperation("CompleteMultipartUpload"));

let req = req
.body(Buffer::from(Bytes::from(content)))
Expand Down Expand Up @@ -499,6 +517,7 @@ impl CosCore {

let req = Request::delete(&url)
.extension(Operation::Delete)
.extension(ServiceOperation("AbortMultipartUpload"))
.body(Buffer::new())
.map_err(new_request_build_error)?;
let req = self.sign(req).await?;
Expand Down Expand Up @@ -536,6 +555,7 @@ impl CosCore {

let req = Request::get(url.finish())
.extension(Operation::List)
.extension(ServiceOperation("ListObjectVersions"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down
11 changes: 11 additions & 0 deletions core/services/obs/src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ impl ObsCore {

let req = req
.extension(Operation::Read)
.extension(ServiceOperation("GetObject"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down Expand Up @@ -166,6 +167,7 @@ impl ObsCore {

let req = req
.extension(Operation::Write)
.extension(ServiceOperation("PutObject"))
.body(body)
.map_err(new_request_build_error)?;

Expand Down Expand Up @@ -200,6 +202,7 @@ impl ObsCore {

let req = req
.extension(Operation::Stat)
.extension(ServiceOperation("HeadObject"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand All @@ -215,6 +218,7 @@ impl ObsCore {

let req = req
.extension(Operation::Delete)
.extension(ServiceOperation("DeleteObject"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down Expand Up @@ -257,6 +261,7 @@ impl ObsCore {

let req = req
.extension(Operation::Write)
.extension(ServiceOperation("AppendObject"))
.body(body)
.map_err(new_request_build_error)?;

Expand All @@ -272,6 +277,7 @@ impl ObsCore {

let req = Request::put(&url)
.extension(Operation::Copy)
.extension(ServiceOperation("CopyObject"))
.header("x-obs-copy-source", &source)
.body(Buffer::new())
.map_err(new_request_build_error)?;
Expand Down Expand Up @@ -306,6 +312,7 @@ impl ObsCore {

let req = Request::get(url.finish())
.extension(Operation::List)
.extension(ServiceOperation("ListObjects"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand All @@ -329,6 +336,7 @@ impl ObsCore {

let req = req
.extension(Operation::Write)
.extension(ServiceOperation("InitiateMultipartUpload"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down Expand Up @@ -362,6 +370,7 @@ impl ObsCore {

let req = req
.extension(Operation::Write)
.extension(ServiceOperation("UploadPart"))
// Set body
.body(body)
.map_err(new_request_build_error)?;
Expand Down Expand Up @@ -398,6 +407,7 @@ impl ObsCore {

let req = req
.extension(Operation::Write)
.extension(ServiceOperation("CompleteMultipartUpload"))
.body(Buffer::from(Bytes::from(content)))
.map_err(new_request_build_error)?;

Expand All @@ -422,6 +432,7 @@ impl ObsCore {

let req = Request::delete(&url)
.extension(Operation::Write)
.extension(ServiceOperation("AbortMultipartUpload"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down
17 changes: 13 additions & 4 deletions core/services/tos/src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ impl TosCore {
);
}

req = req.extension(Operation::Read);
req = req
.extension(Operation::Read)
.extension(ServiceOperation("GetObject"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;

Expand Down Expand Up @@ -276,7 +278,9 @@ impl TosCore {

req = self.insert_metadata_headers(req, size, args);

req = req.extension(Operation::Write);
req = req
.extension(Operation::Write)
.extension(ServiceOperation("PutObject"));

let req = req.body(body).map_err(new_request_build_error)?;

Expand Down Expand Up @@ -348,7 +352,9 @@ impl TosCore {
);
}

req = req.extension(Operation::Stat);
req = req
.extension(Operation::Stat)
.extension(ServiceOperation("HeadObject"));

let req = req.body(Buffer::new()).map_err(new_request_build_error)?;

Expand Down Expand Up @@ -388,6 +394,7 @@ impl TosCore {

let req = req
.extension(Operation::Delete)
.extension(ServiceOperation("DeleteObject"))
.body(Buffer::new())
.map_err(new_request_build_error)?;

Expand Down Expand Up @@ -417,7 +424,9 @@ impl TosCore {
req = req.header(CONTENT_TYPE, "application/json");
req = req.header("CONTENT-MD5", format_content_md5(content.as_bytes()));

req = req.extension(Operation::Delete);
req = req
.extension(Operation::Delete)
.extension(ServiceOperation("DeleteMultipleObjects"));

let req = req
.body(Buffer::from(content))
Expand Down
Loading