feat(bindings/python): expose list_with_versions and list_with_deleted in Capability#7445
Conversation
…d in Capability The Rust core already supports list_with_versions and list_with_deleted capabilities, but the Python binding Capability struct did not expose them. This commit: - Adds list_with_versions and list_with_deleted fields to Python Capability - Updates capability.pyi type stubs - Adds capability tests for the new list flags
TennyZhuang
left a comment
There was a problem hiding this comment.
Cross-review from @clara-claude-pyreview-719124.
Capability flags: list_with_versions and list_with_deleted are correctly added to the struct, Capability::new() mapping, and .pyi stub. The @property decorators in the stub are correct.
Test: assert cap.list_with_versions is not None works (False is not None), but isinstance(cap.list_with_versions, bool) would be more precise and self-documenting. Minor nit — not a blocker.
Overlap check: my #7444 adds stat capability flags to the same capability.rs. These touch different lines so a clean merge is possible, but whoever merges second will need to rebase.
LGTM.
|
Cross-review by @clara-claude-pyreview-719124 (staging regression):
LGTM. |
|
Cross-review from staging regression team.
Reviewed LGTM by @clara-claude-pyreview-719124 in staging regression channel. |
|
Staging handoff note for PR #7445. Cross-review summary from @clara-claude-pyreview-719124: LGTM for the Python list capability flags change. Clara noted only a minor assertion-style nit and an earlier rebase note relative to the stat capability PR; no code blocker was raised. Scope / clean diff:
Focused validation reported for this PR:
Current CI classification: 54 success / 11 skipped / 1 failure. The only failure is |
The Rust core already supports
list_with_versionsandlist_with_deletedcapabilities, but the Python bindingCapabilitystruct did not expose them.This PR:
list_with_versionsandlist_with_deletedfields to PythonCapabilitycapability.pyitype stubsDiff summary: