fix(hf): include folder deletions in git commit payload#7375
Merged
Xuanwo merged 2 commits intoapache:mainfrom Apr 10, 2026
Merged
fix(hf): include folder deletions in git commit payload#7375Xuanwo merged 2 commits intoapache:mainfrom
Xuanwo merged 2 commits intoapache:mainfrom
Conversation
Xuanwo
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
HuggingFace git-based repos support deleting folders via the
deletedFoldersfield in the commit API. The deleter was silently discarding directory-entry paths (those ending with/) instead of passing them through.What changes are included in this PR?
commit_gitasDeletedFolderentries instead of ignoring themtest_remove_all_with_prefix_existsfor HF git-based repos via a feature-gated scheme check instead of a fragile runtime probe writeAre there any user-facing changes?
Yes — deleting a directory path on a git-based HF repo now correctly removes the folder rather than silently doing nothing.
AI Usage Statement
Claude Code was used to assist with this change.