Fixed : Refactor getMultiPartParameterMap to lazy getter to prevent re-parsing consumed input stream (OFBIZ-13369)#970
Open
Lukas-Finster wants to merge 1 commit intoapache:trunkfrom
Conversation
re-parsing consumed input stream (OFBIZ-13369)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: Refactor getMultiPartParameterMap to lazy getter to prevent re-parsing consumed input stream
(OFBIZ-13369)
Explanation: With OFBIZ-13295 ControlFilter#doFilter called UtilHttp#getParameterMap, consuming the request's input stream in the process. Since a multipart stream can only be read once, all subsequent calls return an empty map, which lead to a problem with file uploads in our local setup.
UtilHttp#getMultiPartParameterMap was refactored into a lazy getter: It first checks whether the result is already cached as the request attribute "multiPartMap", and only parses the stream on the first call
Thanks: