Skip to content

Conversation

@Kaben123
Copy link

Note: Please adhere to Contributing Guidelines.

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.

Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.

For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the adc
example. Adding a new uORB driver may require that you run
uorb_listener to verify correct operation.

Pure documentation changes can just be tested with make html
(see docs) and verification of the correct format in your
browser.

PRs without testing information will not be accepted. We will
request test logs.

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
@github-actions github-actions bot added Area: Drivers Drivers issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Jan 23, 2026
@acassis
Copy link
Contributor

acassis commented Jan 23, 2026

@Kaben123 please follow the contribution guide, include the testing to prove it is working, etc. Seems like this commit never was tested, it is reporting primary errors like missing variables

@acassis acassis requested a review from cederom January 23, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Drivers Drivers issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants