arch/arm/nrf{52|53|91}: fix timer timeout value (scaling issue) #18117
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxikrie
requested review from
gustavonihei,
jerpelea,
raiden00pl and
xiaoxiang781216
as code owners
github-actions
bot
added
Arch: arm
maxikrie
force-pushed
the
master
branch
2 times, most recently
from
3f3fd78 to
1bbcc8a
Compare
xiaoxiang781216
previously approved these changes
Jan 23, 2026
raiden00pl
reviewed
Jan 23, 2026
When setting the timeout value, an overflow occurs. Also, if NRF52_TIMER_PER > 1000000, the macro will evaluate to zero in its current form. Signed-off-by: Max Kriegleder <max.kriegleder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When setting the timeout, the timeout value is scaled wrongly. I think this was missed in commit bcf309d @raiden00pl
Impact
This impacts nrf52, nrf53, and nrf91
Testing
I tested it on the nrf52840-dk for a tickless configuration and could confirm that this patch fixes incorrect timeouts.