notifier: prevent DEBUGASSERT recursion during system startup #18104
+13
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical recursion issue in the notifier system that occurs during early
system startup. The problem occurs when DEBUGASSERT is triggered in sched_lock(), which
internally calls panic_notifier_call_chain() - causing a cascading chain of recursive
DEBUGASSERT failures.
The fix adds explicit notifier head pointer checks before executing notifier chains,
preventing unnecessary lock operations on uninitialized notifiers during system startup
and error handling paths.
Problem Description
During early system startup or when DEBUGASSERT fails in the scheduler:
rtcb && rtcb->lockcount < MAX_LOCK_COUNTChanges Made
Atomic Notifier Chain (ATOMIC_NOTIFIER_CALL macro)
Before: